fix(surveys): fix description background style #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -56 B (0%) Total Size: 852 kB
ℹ️ View Unchanged
|
neilkakkar
reviewed
Mar 11, 2024
| @@ -135,8 +135,7 @@ export const style = (appearance: SurveyAppearance | null) => { | |||
| } | |||
| .description { | |||
| font-size: 13px; | |||
| margin-top: 5px; | |||
| opacity: .60; | |||
There was a problem hiding this comment.
iirc this makes photos dimmer, like in this one -> https://us.posthog.com/project/2/surveys/018d3daf-6594-0000-4279-c8bf22b7f6ed -> but indeed doesn't make much sense to me, and people should be able to edit their css to make images lighter if they want to.
There was a problem hiding this comment.
and the preview doesn't have the opacity set either 🤦
neilkakkar
approved these changes
Mar 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Not sure why the opacity was there in the first place, any ideas?
Before
After
(white bg)
(default/blank bg)
