Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send beacon request encoding #1068

Merged
merged 6 commits into from
Mar 11, 2024
Merged

fix: Send beacon request encoding #1068

merged 6 commits into from
Mar 11, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Mar 11, 2024

Changes

I was suspicious that sendBeacon was broken (it isn't) but either way it behaved slightly different to before and needed tests.
Validated it worked in the playground app locally.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

Size Change: -76 B (0%)

Total Size: 852 kB

Filename Size Change
dist/array.full.js 182 kB -24 B (0%)
dist/array.js 124 kB -23 B (0%)
dist/es.js 124 kB -23 B (0%)
dist/module.js 124 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 58.7 kB
dist/surveys-module-previews.js 62.1 kB
dist/surveys.js 58.4 kB

compressed-size-action

@benjackwhite benjackwhite requested a review from pauldambra March 11, 2024 14:48
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@benjackwhite benjackwhite marked this pull request as ready for review March 11, 2024 15:44
@benjackwhite benjackwhite merged commit ada306b into main Mar 11, 2024
14 checks passed
@benjackwhite benjackwhite deleted the fix/beacon branch March 11, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants