fix: Choice of capture compression #1062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some refactoring whilst improving the logic had one side effect - the compression is now a derived value but it is saved in the first event. This means that when the queue is filled, the compression from the first event is used instead of the last one.
To generally make this better I figured it makes sense to be explicit - have a "best-available" option which will select compression as the request is made based on what decide says (with base64 still as the default)
Checklist