Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timezones are fun #1050

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: timezones are fun #1050

merged 1 commit into from
Mar 1, 2024

Conversation

pauldambra
Copy link
Member

Some tests cared about a literal time, which meant if you were not in GMT they might fail

@pauldambra pauldambra requested a review from benjackwhite March 1, 2024 12:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Size Change: 0 B

Total Size: 861 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 185 kB
dist/array.js 126 kB
dist/es.js 126 kB
dist/exception-autocapture.js 12 kB
dist/module.js 127 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 58.6 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

benjackwhite
benjackwhite approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me!

@pauldambra pauldambra merged commit 7a5c16b into main Mar 1, 2024
14 checks passed
@pauldambra pauldambra deleted the fix/timezones-for-fun-and-great-good branch March 1, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldambra @benjackwhite