Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure ingestion domains follow the same logic. #1049

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

benjackwhite
Copy link
Collaborator

Changes

Over time we will start moving people to new ingestion domains - we want to ensure this is correctly handled as even now someone might accidentally pick the wrong thing.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Mar 1, 2024
@benjackwhite benjackwhite requested a review from danielxnj March 1, 2024 12:09
Copy link

github-actions bot commented Mar 1, 2024

Size Change: +780 B (0%)

Total Size: 862 kB

Filename Size Change
dist/array.full.js 185 kB +195 B (0%)
dist/array.js 126 kB +195 B (0%)
dist/es.js 126 kB +195 B (0%)
dist/module.js 127 kB +195 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 58.6 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@benjackwhite benjackwhite requested a review from pauldambra March 4, 2024 07:46
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to quote marius: "looks like code" 🤣

@benjackwhite benjackwhite merged commit 523576c into main Mar 6, 2024
13 checks passed
@benjackwhite benjackwhite deleted the fix/router branch March 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants