Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): survey popover improvements #1029

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Feb 19, 2024

Changes

Quick updates to improve accessibility with increased font sizes and more subtle grayscale button

addresses a majority of PostHog/posthog#20346

before:
Screenshot 2024-02-17 at 2 49 07 PM

after:
Screenshot 2024-02-17 at 2 48 21 PM

Checklist

  • [x ] Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

github-actions bot commented Feb 19, 2024

Size Change: +64 B (0%)

Total Size: 862 kB

Filename Size Change
dist/surveys.esm.js 64.2 kB +32 B (0%)
dist/surveys.js 64.3 kB +32 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 183 kB
dist/array.js 125 kB
dist/es.js 125 kB
dist/exception-autocapture.js 12 kB
dist/module.js 125 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 58.6 kB

compressed-size-action

@liyiy liyiy added the bump patch Bump patch version when this PR gets merged label Feb 19, 2024
@liyiy liyiy merged commit cdfd10a into main Feb 19, 2024
13 checks passed
@liyiy liyiy deleted the survey-popover-improvements branch February 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant