-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow changing persistence #1025
Conversation
Size Change: +18.5 kB (+2%) Total Size: 863 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i trust you ran it locally and since the new test passes this looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look through the code, but didn't run. What I saw looks good, and seconding Paul: seems like the test passes, so I trust it works.
Changes
Fixes #1024
Allows doing something like this:
Follow up
Checklist