Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow custom events when idle #1013

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Conversation

pauldambra
Copy link
Member

We want to use custom events more... and we're using one to record when a session goes idle - which we immediately drop because the session is idle 🤦

Lets allow custom events into the buffer while idle

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Feb 10, 2024
@pauldambra pauldambra requested a review from a team February 10, 2024 13:41
Copy link

github-actions bot commented Feb 10, 2024

Size Change: +180 B (0%)

Total Size: 781 kB

Filename Size Change
dist/array.full.js 183 kB +45 B (0%)
dist/array.js 124 kB +45 B (0%)
dist/es.js 124 kB +45 B (0%)
dist/module.js 125 kB +45 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 105 kB
dist/recorder.js 58.6 kB
dist/surveys.js 48.8 kB

compressed-size-action

@marandaneto
Copy link
Member

which we immediately drop because the session is idle 🤦

Makes sense 😅 idle logic was 🤌

@pauldambra pauldambra merged commit efb5bbd into main Feb 11, 2024
13 checks passed
@pauldambra pauldambra deleted the fix/allow-custom-events-when-idle branch February 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants