Skip to content

Commit

Permalink
parameterise tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@pauldambra
pauldambra committed Feb 6, 2024
1 parent 5d3c2a3 commit cb2ce85
Showing 1 changed file with 64 additions and 80 deletions.
144 changes: 64 additions & 80 deletions src/__tests__/autocapture-utils.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -180,100 +180,84 @@ describe(`Autocapture utility functions`, () => {
return finalElement
}

it('will capture when there is no allowlist', () => {
const clickTarget = makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button', id: 'in-allowlist' },
{ tag: 'svg' },
])
expect(shouldCaptureDomEvent(clickTarget, makeMouseEvent({}))).toBe(true)
})

it('will capture when there is a parent matching the allow list', () => {
const clickTarget = makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button', id: 'in-allowlist' },
{ tag: 'svg' },
])
expect(
shouldCaptureDomEvent(clickTarget, makeMouseEvent({}), {
it.each([
[
'when there is no allowlist',
makeSingleBranchOfDomTree([{ tag: 'div' }, { tag: 'button', id: 'in-allowlist' }, { tag: 'svg' }]),
undefined,
true,
],
[
'when there is a parent matching the allow list',
makeSingleBranchOfDomTree([{ tag: 'div' }, { tag: 'button', id: 'in-allowlist' }, { tag: 'svg' }]),
{
css_selector_allowlist: ['[id]'],
})
).toBe(true)
})

it('will capture when the click target is matching in the allow list', () => {
const clickTarget = makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button' },
{ tag: 'svg', id: 'in-allowlist' },
])
expect(
shouldCaptureDomEvent(clickTarget, makeMouseEvent({}), {
},
true,
],
[
'when the click target is matching in the allow list',
makeSingleBranchOfDomTree([{ tag: 'div' }, { tag: 'button' }, { tag: 'svg', id: 'in-allowlist' }]),
{
css_selector_allowlist: ['[id]'],
})
).toBe(true)
})

it('does not capture when the parent does not match the allowlist', () => {
const clickTarget = makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button', id: '[id=not-the-configured-value]' },
{ tag: 'svg' },
])
expect(
shouldCaptureDomEvent(clickTarget, makeMouseEvent({}), {
},
true,
],
[
'when the parent does not match the allowlist',
makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button', id: '[id=not-the-configured-value]' },
{ tag: 'svg' },
]),
{
// the click was detected on the SVG, but the button is not in the allow list,
// so we should detect the click
css_selector_allowlist: ['in-allowlist'],
})
).toBe(false)
})

it('does not capture when the click target (and none of its parents) does not match the allowlist', () => {
const clickTarget = makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button' },
{ tag: 'svg', id: '[id=not-the-configured-value]' },
])
expect(
shouldCaptureDomEvent(clickTarget, makeMouseEvent({}), {
},
false,
],
[
'when the click target (and none of its parents) does not match the allowlist',
makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button' },
{ tag: 'svg', id: '[id=not-the-configured-value]' },
]),
{
css_selector_allowlist: ['in-allowlist'],
})
).toBe(false)
})

it('can combin allow lists', () => {
const clickTarget = makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button', id: 'in-allowlist' },
{ tag: 'svg' },
])
expect(
shouldCaptureDomEvent(clickTarget, makeMouseEvent({}), {
},
false,
],
[
'when combining allow lists',
makeSingleBranchOfDomTree([{ tag: 'div' }, { tag: 'button', id: 'in-allowlist' }, { tag: 'svg' }]),
{
// the tree for the click does have an id
css_selector_allowlist: ['[id]'],
// but we only detect if there is an img in the tree
element_allowlist: ['img'],
})
).toBe(false)
})

it('can combine allow lists - but it considers them separately', () => {
const clickTarget = makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button', id: 'in-allowlist' },
{ tag: 'img' },
{ tag: 'svg' },
])
expect(
shouldCaptureDomEvent(clickTarget, makeMouseEvent({}), {
},
false,
],
[
'combine allow lists - but showing it considers them separately',
makeSingleBranchOfDomTree([
{ tag: 'div' },
{ tag: 'button', id: 'in-allowlist' },
{ tag: 'img' },
{ tag: 'svg' },
]),
{
// the tree for the click does have an id
css_selector_allowlist: ['[id]'],
// and the tree for the click does have an img
element_allowlist: ['img'],
})
).toBe(true)
},
true,
],
])('correctly respects the allow list: %s', (_, clickTarget, autoCaptureConfig, shouldCapture) => {
expect(shouldCaptureDomEvent(clickTarget, makeMouseEvent({}), autoCaptureConfig)).toBe(shouldCapture)
})
})
})
Expand Down

0 comments on commit cb2ce85

Please sign in to comment.