fix(surveys): clearer user property names

PostHog · Oct 26, 2023 · 8e60433 · 8e60433
1 parent 559ee24
commit 8e60433
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/__tests__/extensions/surveys.js b/src/__tests__/extensions/surveys.js
@@ -60,7 +60,7 @@ describe('survey display logic', () => {
             $survey_name: 'Test survey 1',
             sessionRecordingUrl: undefined,
             $set: {
-                '$survey_dismiss/testSurvey1': true,
+                '$survey_dismissed/testSurvey1': true,
             },
         })
         expect(localStorage.getItem(`seenSurvey_${mockSurveys[0].id}`)).toBe('true')

diff --git a/src/extensions/surveys.ts b/src/extensions/surveys.ts
@@ -384,7 +384,7 @@ export const createOpenTextOrLinkPopup = (
                     $survey_response: surveyQuestionType === 'open' ? e.target.survey.value : 'link clicked',
                     sessionRecordingUrl: posthog.get_session_replay_url?.(),
                     $set: {
-                        [`$survey_response/${survey.id}`]: true,
+                        [`$survey_responded/${survey.id}`]: true,
                     },
                 })
                 if (surveyQuestionType === 'link') {
@@ -461,7 +461,7 @@ export const addCancelListeners = (
                 $survey_id: surveyId,
                 sessionRecordingUrl: posthog.get_session_replay_url?.(),
                 $set: {
-                    [`$survey_dismiss/${surveyId}`]: true,
+                    [`$survey_dismissed/${surveyId}`]: true,
                 },
             })
         })