Skip to content

Commit

Permalink
feat: retry count in url (#864)
Browse files Browse the repository at this point in the history
During an incident we are sometimes flooded with retries from the JS SDK.

Or at least we believe we are. And, when we are we don't know how many retries there are.

Let's add the retry count to the URL so we can figure things out by inspecting the capture logs

Tested locally that I can still ingest events etc
  • Loading branch information
pauldambra authored Oct 30, 2023
1 parent 6c4961f commit 0fe7971
Show file tree
Hide file tree
Showing 43 changed files with 1,788 additions and 1,589 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/testcafe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest

strategy:
matrix:
matrix:
browserstack:
- chrome
- ie
Expand Down
1 change: 1 addition & 0 deletions cypress/support/e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import 'given2/setup'
// require('./commands')

// Add console errors into cypress logs.
// eslint-disable-next-line no-undef
Cypress.on('window:before:load', (win) => {
cy.spy(win.console, 'error')
cy.spy(win.console, 'warn')
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/posthog-core.js.snap
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`__compress_and_send_json_request handles base64 compression 1`] = `
exports[`posthog core __compress_and_send_json_request handles base64 compression 1`] = `
Array [
Array [
"/e/",
Expand Down
55 changes: 0 additions & 55 deletions src/__tests__/__snapshots__/send-request.js.snap

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import {
ErrorProperties,
unhandledRejectionToProperties,
} from '../../../extensions/exception-autocapture/error-conversion'
import { _isNull } from '../../../utils'

import { _isNull } from '../../../utils/type-utils'

// ugh, jest
// can't reference PromiseRejectionEvent to construct it 🤷
Expand Down
3 changes: 2 additions & 1 deletion src/__tests__/gdpr-utils.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import sinon from 'sinon'

import * as gdpr from '../gdpr-utils'
import { _isNull } from '../utils'

import { _isNull } from '../utils/type-utils'

const TOKENS = [
`test-token`,
Expand Down
Loading

0 comments on commit 0fe7971

Please sign in to comment.