Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm libev dependency #229

Closed
wants to merge 2 commits into from
Closed

Conversation

ardrabczyk
Copy link
Contributor

I don't know if this PR is expected. I was building i3 and I found libev listed in the requirements but no slackbuild for it so I fixed it and all other packages. When are changes like that supposed to be added after a package is removed from SlackBuilds?

It has been added to Slackware
<https://git.slackware.nl/current/commit/?id=25d8b003ae67298d8fb5e2151a76877a5e7b6e56>.

I used the following one-liner to find all packages that require
libev:

    $ find . -name '*.info' -print0 | xargs -0 grep --color -P '(?:^REQUIRES=.*\K)libev\b'

And the following one-liner to automatically remove libev dependency
from all *.info files:

    $ find . -name '*.info' -type f -print0 | xargs -0 gawk -i inplace '/^REQUIRES=.+libev/ {gsub(/ ?\<libev\> ?/, " "); gsub(/" /, "\""); gsub(/ "/, "\"")} 1'
Copy link

reverse dependencies - desktop/i3-gaps

None

Copy link

reverse dependencies - multimedia/dvblast

None

Copy link

reverse dependencies - desktop/i3

  • desktop/bumblebee-status
  • desktop/i3-easyfocus

Copy link

reverse dependencies - desktop/i3lock

None

Copy link

reverse dependencies - accessibility/unclutter-xfixes

None

Copy link

reverse dependencies - audio/musikcube

None

Copy link

reverse dependencies - network/ocserv

None

Copy link

reverse dependencies - network/shadowsocks-libev

None

Copy link

reverse dependencies - libraries/ngtcp2

  • network/curl-quic

Copy link

reverse dependencies - desktop/picom

None

Copy link

reverse dependencies - perl/perl-EV

  • perl/perl-Coro

Copy link

✅ sbolint - multimedia/dvblast ✅

dvblast: NOTE: dvblast.SlackBuild:65: LIBDIRSUFFIX gets set, but never used.
sbolint: dvblast checks out OK

Copy link

✅ sbolint - desktop/i3 ✅

sbolint: i3 checks out OK

Copy link

✅ sbolint - network/ocserv ✅

sbolint: ocserv checks out OK

Copy link

✅ sbolint - audio/musikcube ✅

sbolint: musikcube checks out OK

Copy link

✅ sbolint - libraries/ngtcp2 ✅

sbolint: ngtcp2 checks out OK

Copy link

✅ sbolint - accessibility/unclutter-xfixes ✅

unclutter-xfixes: NOTE: unclutter-xfixes.SlackBuild:44: SLKCFLAGS gets set, but never used.
unclutter-xfixes: NOTE: unclutter-xfixes.SlackBuild:45: LIBDIRSUFFIX gets set, but never used.
sbolint: unclutter-xfixes checks out OK

Copy link

✅ sbolint - desktop/i3lock ✅

i3lock: NOTE: i3lock.SlackBuild:63: SLKCFLAGS gets set, but never used.
i3lock: NOTE: i3lock.SlackBuild:64: LIBDIRSUFFIX gets set, but never used.
sbolint: i3lock checks out OK

Copy link

✅ sbolint - desktop/picom ✅

picom: NOTE: picom.SlackBuild:64: LIBDIRSUFFIX gets set, but never used.
sbolint: picom checks out OK

Copy link

✅ sbolint - desktop/i3-gaps ✅

sbolint: i3-gaps checks out OK

Copy link

✅ sbolint - network/shadowsocks-libev ✅

sbolint: shadowsocks-libev checks out OK

Copy link

✅ sbolint - perl/perl-EV ✅

perl-EV: NOTE: perl-EV.SlackBuild:65: SLKCFLAGS gets set, but never used.
perl-EV: NOTE: perl-EV.SlackBuild:66: LIBDIRSUFFIX gets set, but never used.
sbolint: perl-EV checks out OK

@ardrabczyk
Copy link
Contributor Author

ok, I read wiki:

note that I remove from the repository whatever gets added to Slackware current (also under a different name - for example six as python-six) but I don't remove it from the REQUIRES line of the *.info files: this may confuse your third-party semi-automated tool because it won't find packages listed as dependencies but it actually, like you, should just ignore them as they should already be present in your Slackware current full installation (the only platform supported by this repository).

So this PR can be removed.

@ardrabczyk ardrabczyk closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant