add integer support to balance algorithm; apply formatting #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
This is definitely an improvement over what it was doing before so we can merge.
I wonder if it is worth writing this so it doesn't change the type of the output compared to the input property.
Also, maybe make this return a result instead of 0 balances if the property is not convertible to float?
| @@ -58,7 +58,7 @@ fn balance_per_node<'graph, G: GraphViewOps<'graph>, GH: GraphViewOps<'graph>, C | |||
| prop.temporal().get(name).map(|val| { | |||
| val.values() | |||
| .into_iter() | |||
| .map(|valval| valval.into_f64().unwrap_or(0.0f64)) | |||
| .map(|valval| valval.as_f64().unwrap_or(0.0f64)) | |||
There was a problem hiding this comment.
Should this algorithm have a check for the type of the property instead of just returning all 0 if it happens to be a string or something else that can't be converted to float?
There was a problem hiding this comment.
Another alternative is that edge weights default to 1. @miratepuffin @Alnaimi- any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add integer support to balance algorithm.
Why are the changes needed?
Fixes #1406. Previously, edge properties had to be converted to floats. Now ints and floats both work as expected.
Does this PR introduce any user-facing change? If yes is this documented?
No method signatures have been affected.
How was this patch tested?
I updated the Rust unit-test to test ints and it passes.
Are there any further changes required?
N/A