Refactor Node Temporal properties #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmurariu
force-pushed
the
node_tprops_refactor2
branch
from
a4d4cde to
ae17444
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 2776818 | Previous: 250736e | Ratio |
|---|---|---|---|
lotr_graph_window_50_layered/iterate nodes |
12278 ns/iter (± 14) |
6044 ns/iter (± 3) |
2.03 |
This comment was automatically generated by workflow using github-action-benchmark.
fabianmurariu
force-pushed
the
node_tprops_refactor2
branch
from
21706cf to
0110c82
Compare
fabianmurariu
force-pushed
the
node_tprops_refactor2
branch
from
3100d43 to
eda03ac
Compare
ljeub-pometry
requested changes
Dec 17, 2024
raphtory/src/core/storage/mod.rs
Outdated
Comment on lines
825
to
839
| pub struct EntryMut<'a, NS: 'a> { | ||
| i: usize, | ||
| guard: parking_lot::RwLockWriteGuard<'a, Vec<T>>, | ||
| guard: NS, | ||
| _pd: PhantomData<&'a ()>, | ||
| } |
There was a problem hiding this comment.
Would it have been easier to have separate structs for the ref and owned variants?
| @@ -56,7 +56,7 @@ impl From<&PyTemporalProperties> for PyTemporalPropsCmp { | |||
| value | |||
| .histories() | |||
| .into_iter() | |||
| .map(|(k, v)| (k, v.into())) | |||
| .filter_map(|(k, v)| (v.len() > 0).then(|| (k, v.into()))) | |||
There was a problem hiding this comment.
we should discuss the semantics
fabianmurariu
force-pushed
the
node_tprops_refactor2
branch
from
e60648c to
2ea6bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For nodes separate edge originating timestamps from temporal properties originating timestamps
Why are the changes needed?
Correctness
Does this PR introduce any user-facing change? If yes is this documented?
API changes
How was this patch tested?
Tests
Are there any further changes required?
Yes, design a History struct