Document template fixes #1894
Merged
Document template fixes #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricopinazo
commented
Dec 17, 2024
| @@ -201,7 +204,10 @@ impl DocumentTemplate { | |||
| let mut env = Environment::new(); | |||
| let template = build_template(&mut env, template); | |||
| match template.render(NodeTemplateContext::from(node)) { | |||
| Ok(document) => Box::new(std::iter::once(document.into())), | |||
| Ok(mut document) => { | |||
| truncate(&mut document); | |||
There was a problem hiding this comment.
mention this in the docs / try to make this configurable
There was a problem hiding this comment.
add helper funtion node.generate_document() to allow debugging
There was a problem hiding this comment.
ideally simply use multi documents for big documents
| {% for (key, values) in temporal_properties|items %} | ||
| {{ key }}: | ||
| {% for (time, value) in values %} | ||
| - changed to {{ value }} at {{ time|datetimeformat }} |
There was a problem hiding this comment.
allow choosing between numbers or timestamps in the API
miratepuffin
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Having default templates is a first step towards a smart search view on the generic UI
Does this PR introduce any user-facing change? If yes is this documented?
Yes, and the docstrings were updated accordingly
How was this patch tested?
Are there any further changes required?
No