Tidy/ingestor #1714
Merged
Tidy/ingestor #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # python/tests/test_disk_graph.py # raphtory/src/core/utils/errors.rs # raphtory/src/io/arrow/dataframe.rs # raphtory/src/io/arrow/df_loaders.rs # raphtory/src/io/arrow/mod.rs # raphtory/src/io/arrow/prop_handler.rs # raphtory/src/io/parquet_loaders.rs # raphtory/src/python/graph/disk_graph.rs # raphtory/src/python/graph/graph.rs # raphtory/src/python/graph/graph_with_deletions.rs # raphtory/src/python/graph/io/pandas_loaders.rs
# Conflicts: # python/python/raphtory/__init__.pyi # python/python/raphtory/graphql/__init__.pyi # raphtory/src/python/graph/graph_with_deletions.rs
miratepuffin
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For the Pandas/Parquet loaders we want to do the following:
load_from_pandasandload_from_parquet- these had WAY too many arguments and were very confusing.load_edges_deletions_from_parquettoload_edge_deletions_from_parquetandload_edges_deletions_from_pandastoload_edge_deletions_from_pandasto be gramantically correct.layer/layer_in_dfwithlayerandlayer_col: Option<&str>and simply raise a runtime error if both are specified at the same timenode_type/node_type_in_dfwithnode_typeandnode_type_col: Option<&str>and simply raise a runtime error if both are specified at the same timeWhy are the changes needed?
Improving the user experience when using the most typical ways of loading data into Raphtory
Does this PR introduce any user-facing change? If yes is this documented?
Yes and yes
How was this patch tested?
Via the current suite of loader tests
Issues
Fixes #1675
Fixes #1674
Fixes #1673
Are there any further changes required?
The loaders need to be parallelised, now that they are chunked.