Make the edge storage more columnar to reduce memory usage #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmurariu
force-pushed
the
mem_optim2
branch
3 times, most recently
from
e3b30b5 to
4cec8cc
Compare
fabianmurariu
changed the title
fabianmurariu
force-pushed
the
mem_optim2
branch
from
827d245 to
1732326
Compare
ljeub-pometry
requested changes
Jul 2, 2024
| } | ||
|
|
||
| impl<'a, O, OUT> GenLockedIter<'a, O, OUT> { | ||
| pub fn from<'b>( |
There was a problem hiding this comment.
what is this lifetime doing here?
There was a problem hiding this comment.
indeed it is useless yet the self_referencing macro fails without that lifetime
ljeub-pometry
approved these changes
Jul 2, 2024
Comment on lines
115
to
129
|
|
||
| // #[inline] | ||
| // pub(crate) fn entry(&self, id: EID) -> EdgeRGuard { | ||
| // self.get_edge(id) | ||
| // } | ||
|
|
||
| // #[inline] | ||
| // pub(crate) fn entry_mut(&self, id: EID) -> EdgeWGuard { | ||
| // self.get_edge_mut(id) | ||
| // } | ||
|
|
||
| // #[inline] | ||
| // pub(crate) fn entry_arc(&self, id: EID) -> EdgeArcGuard { | ||
| // self.get_edge_arc(id) | ||
| // } |
There was a problem hiding this comment.
you left in some comments
Comment on lines
8
to
12
|
|
||
| use super::edge_entry::EdgeStorageEntry; | ||
| use crate::db::api::storage::variants::storage_variants3::StorageVariants; | ||
|
|
||
| use rayon::iter::ParallelIterator; | ||
| use std::sync::Arc; |
There was a problem hiding this comment.
still some blank lines which means this didn't get fully simplified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
change the layout of the edges from rows to columns
Why are the changes needed?
reduce memory usage
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Unit test
Issues
closes #1667
Are there any further changes required?