Parquet loader #1666
Merged
Parquet loader #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam-880
requested review from
ljeub-pometry,
fabianmurariu and
miratepuffin
and removed request for
ljeub-pometry and
fabianmurariu
ljeub-pometry
previously requested changes
Jun 24, 2024
# Conflicts: # raphtory/src/core/utils/errors.rs # raphtory/src/io/arrow/mod.rs # raphtory/src/python/graph/graph_with_deletions.rs
There was a problem hiding this comment.
Some small changes/suggestions, but otherwise looking good.
There are a couple of comments that I dont think need to go in this PR, but we probably want to get them tidied before the next major release.
Also for the testing it probably makes sense to load the graphs via pandas, parquet, raw, etc and see if they all create the same graph - can be part of a test refactoring ticket.
This was referenced Jun 26, 2024
# Conflicts: # examples/rust/src/bin/btc/main.rs # examples/rust/src/bin/lotr/main.rs # raphtory/src/io/csv_loader.rs
miratepuffin
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Impl #1660
Why are the changes needed?
Same as above
Does this PR introduce any user-facing change? If yes is this documented?
Yes
How was this patch tested?
Unit tests
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close,closes,closed,fix,fixes,fixed,resolve,resolves,resolved.Please delete this text before creating your PR
Are there any further changes required?
No