Extra benches #1651
Merged
Extra benches #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
approved these changes
Jun 10, 2024
ljeub-pometry
previously requested changes
Jun 10, 2024
Comment on lines
330
to
334
| graph.edge_window_layers( | ||
| edge.edge, | ||
| active_t.saturating_sub(5)..active_t + 5, | ||
| &LayerIds::All, | ||
| ) |
There was a problem hiding this comment.
Can we test the high-level api instead? i.e. graph.window(active_t.saturating_sub(5)..active_t + 5).explode_layers().iter().for_each(|e| black_box(e))
Also, you are not actually consuming the iterator?
There was a problem hiding this comment.
completely missed that being an iterator 😄
| @@ -28,6 +31,72 @@ pub fn graph(c: &mut Criterion) { | |||
| None, | |||
| ); | |||
| graph_window_group_10.finish(); | |||
|
|
|||
| // subgraph | |||
| let mut rng = rand::thread_rng(); | |||
There was a problem hiding this comment.
Should give this a seed so we don't get variability due to choosing different nodes
Comment on lines
78
to
102
| /// # Arguments | ||
| /// | ||
| /// * `shards` - The number of shards to use for the graph | ||
| /// | ||
| /// Returns: | ||
| /// | ||
| /// - A Result containing the graph or an error | ||
| pub fn sx_superuser_graph() -> Result<Graph, Box<dyn std::error::Error>> { | ||
| pub fn sx_superuser_graph(num_layers: Option<usize>) -> Result<Graph, Box<dyn std::error::Error>> { | ||
| let graph = Graph::new(); | ||
| CsvLoader::new(sx_superuser_file()?) | ||
| .set_delimiter(" ") | ||
| .load_into_graph(&graph, |edge: TEdge, g: &Graph| { | ||
| g.add_edge(edge.time, edge.src_id, edge.dst_id, NO_PROPS, None) | ||
| if let Some(layer) = num_layers | ||
| .map(|num_layers| calculate_hash(&(edge.src_id, edge.dst_id)) % num_layers as u64) | ||
| .map(|id| id.to_string()) | ||
| { | ||
| g.add_edge( | ||
| edge.time, | ||
| edge.src_id, | ||
| edge.dst_id, | ||
| NO_PROPS, | ||
| Some(layer.as_str()), | ||
| ) | ||
| .expect("Error: Unable to add edge"); | ||
| } else { | ||
| g.add_edge(edge.time, edge.src_id, edge.dst_id, NO_PROPS, None) | ||
| .expect("Error: Unable to add edge"); | ||
| } |
There was a problem hiding this comment.
Can we make this a separate function in the benchmark instead? It is a really strange parameter to have for this dataset
fabianmurariu
force-pushed
the
extra_benches
branch
from
d338ed1 to
22e03b1
Compare
miratepuffin
dismissed
ljeub-pometry’s stale review
merging so that we can check your PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To catch potential slowdowns sooner
Why are the changes needed?
we failed to catch slowdowns and they made it into master
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Issues
Are there any further changes required?