supported empty node types while node type filtering #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphtory/src/db/graph/graph.rs
Outdated
| @@ -200,6 +200,7 @@ mod db_tests { | |||
| use super::*; | |||
| use crate::{ | |||
| algorithms::components::weakly_connected_components, | |||
| arrow::graph_impl::ArrowGraph, | |||
There was a problem hiding this comment.
remove this and good to merge
miratepuffin
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support empty node type filter. For example, node_types = ["a", ""]
Why are the changes needed?
Same as above
Does this PR introduce any user-facing change? If yes is this documented?
Yes
How was this patch tested?
Unit test
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close,closes,closed,fix,fixes,fixed,resolve,resolves,resolved.Please delete this text before creating your PR
Are there any further changes required?
No