Motifs tidy ii #1623
Merged
Motifs tidy ii #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itrary eval nodes and edges
ljeub-pometry
approved these changes
May 28, 2024
| @@ -445,6 +443,7 @@ mod motifs_test { | |||
| let actual = binding | |||
| .iter() | |||
| .map(|(k, v)| (k, v[0].clone())) | |||
| .into_iter() | |||
There was a problem hiding this comment.
This is not needed?
…r triangles wasn't matching with api description
|
I unfortunately found what was secretly an n^2 routine in the local motif counting -- the algo was never seeming to finish on the large dataset and I found I was unintentionally calling neighbours about n^2 times. Changed now and it seems to be about the same time as the global motifs, just a little longer which is what I was expecting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
small tidy up of variable names/removing dead code and also making a small optimisation
fix local motifs for windowed graphs.
Why are the changes needed?
Noticed I'd left some dead code in there. Optimisation was suggested a while ago by @LJeub which seems to shave off a few seconds in Alphabay but may be even better for bigger datasets.
Local motifs was throwing an error for nodes filtered out by window.
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Alphabay motifs produce same output in similar to slightly shorter time. Added windowed graph test for local motifs.
Issues
N/A
Are there any further changes required?
No