Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/performance #1622

Merged
merged 10 commits into from
May 28, 2024
Merged

Fix/performance #1622

merged 10 commits into from
May 28, 2024

Conversation

ljeub-pometry
Copy link
Collaborator

@ljeub-pometry ljeub-pometry commented May 27, 2024

What changes were proposed in this pull request?

  • Make it possible to get eval nodes and edges based on node ids to avoid hitting the locks
  • Streamline the interaction with the private arrow apis

Why are the changes needed?

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Are there any further changes required?

Copy link
Collaborator

@narnolddd narnolddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! (focusing mainly on the top level api changes/changes to the motifs algo rather than storage bits ofc). Will be really helpful being able to access edges by id in eval mode.

@miratepuffin miratepuffin merged commit 8987374 into master May 28, 2024
13 checks passed
@miratepuffin miratepuffin deleted the fix/performance branch May 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants