fix issue with InnerTemopralGraph implementation and impl load from p… #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anda and other missing APIs for GraphwithDeletions
Haaroon
previously approved these changes
Mar 22, 2024
Haaroon
suggested changes
Mar 22, 2024
Haaroon
approved these changes
Mar 27, 2024
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
#1543) * fix issue with InnerTemopralGraph implementation and impl load from panda and other missing APIs for GraphwithDeletions * props renamed to properties * fmt * add tests for layers_in_df being true for both graph and graphwithdeletions * missing cols should fail early * impl node_type_in_df for loaders, fix and impl tests * impl load edge with deletions for graphwithdeletions * fnmt * fix tests * fix tests * fmt * fix notebook * add review changes * fmt * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Impl missing APIs
Does this PR introduce any user-facing change? If yes is this documented?
Yes, added doc comments
How was this patch tested?
pytests
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close,closes,closed,fix,fixes,fixed,resolve,resolves,resolved.Please delete this text before creating your PR
Are there any further changes required?
no