change the windowing semantics to not enforce nesting by default #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add helper methods for creating nested windows
…port unbounded windows
ljeub-pometry
force-pushed
the
feature/TimeSemantics
branch
from
6f3e299 to
c85ba41
Compare
miratepuffin
approved these changes
Jan 11, 2024
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* change the windowing semantics to not enforce nesting by default and add helper methods for creating nested windows * add shrink to python and gql * switch NaiveDateTime to DateTime<Utc> for return types (WIP) * fix inconsistent date time methods * clean up warnings * fix time conversions * update windowing semantics to allow resetting on one-hop only and support unbounded windows * fix python tests * make some of TimeOps internal-only and remove IntoOptTime * fix the benchmarks * add test * fix latest time for windowed edges in GraphWithDeletions * more python tests for deletions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
before,afterandwindowshould just reset the bounds and no longer create nested windowsshrink_start,shrink_endandshrink_windowfor creating nested windowsWhy are the changes needed?
old semantics meant it was impossible to get history information after calling
atfor exampleDoes this PR introduce any user-facing change? If yes is this documented?
yes, need to document all of this
How was this patch tested?
the updated tests
Issues
resolves #1444
Are there any further changes required?