Zaks Karate Club Graph #1326
Merged
Zaks Karate Club Graph #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/vertex-id-algo-v3 #1326 +/- ##
==========================================================
Coverage 57.85% 57.86%
==========================================================
Files 186 188 +2
Lines 20149 20162 +13
==========================================================
+ Hits 11658 11666 +8
- Misses 8491 8496 +5
☔ View full report in Codecov by Sentry. |
miratepuffin
previously requested changes
Oct 11, 2023
Haaroon
added a commit
that referenced
this pull request
Oct 19, 2023
…d Zaks Karate Club (#1327) * checkpoint, need to fix tests * im so happy it works :D * remove type_name param * algorithm result tests complete, new fmt, fixed group_by, fixed all types * renamed old algorithm result, changed base result type to a hashmap instead of vector due to potential issues with sparse vectors if the dataset is large, added missing G type for the graph, brought back results type * fix bad 0 checking * macro magic but partially implemented * added the extra macros, added all missing functions, removed all pointers for clones (:vomit: pyo3) * algorithm result object + all macros is complete in both rust and python * fixed reciprocity, fixed centrality * fixed pagerank, fixed graphql new type issues * balance algorithm complete * sssp fixed * sssp forgot le lib * temporal reachability fixed * hits fixed * connected components nearly fixed, last test * removed bad test * three node motif completed, algorithm result complte * good bye bugs * removed all warnings * fix lotr bug * i think i fixed hulong * fix dusty benchmark * rename macro rules, fix doctests * implement debug for algo result * fix pytests * Zaks Karate Club Graph (#1326) * betweenness centrality for a directed graph with and without normalisation * cleanup * swapped to algorithm result, added rust docs * ported to python, added python docs, added python test * fix formatting * karate club graph, but its half working, adding 1 extra node and way too many edges * fixed issue with rows * betweeness has float calc differences but largely the same * fix test * fixes issue with python? * port betweeness centrality to new algo object and fix over python tests * Changed State to use Internal ID everywhere, fixed most of the algorithms, fixed the tests * fixed all the algos * fn name changes * added very basic hashing to allow get_all to return a vertex object * vertex view now returned by algo rest * fix python algo result for vertexview * reorder tests * implemented custom debug fmt display for vertex view, implemented custom display fmt, fixed algorithm tests, fixed all rust issues * extended richcmp for python objects, fixed all python tests * connected_components.rs passes * moved algos * resolved comments * changes due to comments * windows works, layers dont * added tests for windowed graphs * complete! * bad comments for ubuntu * bad colon
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
…d Zaks Karate Club (#1327) * checkpoint, need to fix tests * im so happy it works :D * remove type_name param * algorithm result tests complete, new fmt, fixed group_by, fixed all types * renamed old algorithm result, changed base result type to a hashmap instead of vector due to potential issues with sparse vectors if the dataset is large, added missing G type for the graph, brought back results type * fix bad 0 checking * macro magic but partially implemented * added the extra macros, added all missing functions, removed all pointers for clones (:vomit: pyo3) * algorithm result object + all macros is complete in both rust and python * fixed reciprocity, fixed centrality * fixed pagerank, fixed graphql new type issues * balance algorithm complete * sssp fixed * sssp forgot le lib * temporal reachability fixed * hits fixed * connected components nearly fixed, last test * removed bad test * three node motif completed, algorithm result complte * good bye bugs * removed all warnings * fix lotr bug * i think i fixed hulong * fix dusty benchmark * rename macro rules, fix doctests * implement debug for algo result * fix pytests * Zaks Karate Club Graph (#1326) * betweenness centrality for a directed graph with and without normalisation * cleanup * swapped to algorithm result, added rust docs * ported to python, added python docs, added python test * fix formatting * karate club graph, but its half working, adding 1 extra node and way too many edges * fixed issue with rows * betweeness has float calc differences but largely the same * fix test * fixes issue with python? * port betweeness centrality to new algo object and fix over python tests * Changed State to use Internal ID everywhere, fixed most of the algorithms, fixed the tests * fixed all the algos * fn name changes * added very basic hashing to allow get_all to return a vertex object * vertex view now returned by algo rest * fix python algo result for vertexview * reorder tests * implemented custom debug fmt display for vertex view, implemented custom display fmt, fixed algorithm tests, fixed all rust issues * extended richcmp for python objects, fixed all python tests * connected_components.rs passes * moved algos * resolved comments * changes due to comments * windows works, layers dont * added tests for windowed graphs * complete! * bad comments for ubuntu * bad colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a karate club graph generator
Why are the changes needed?
To quickly tests graphs
Does this PR introduce any user-facing change? If yes is this documented?
Yes
How was this patch tested?
Test in rust and python
Issues
resolves #1305
Are there any further changes required?