Efficient version for global motif counts #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple time deltas
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
|
Also just edited some python docs for balance that were referring to rust objects. |
miratepuffin
approved these changes
Nov 27, 2023
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* array of accumulators works and efficient algo for global motifs with multiple time deltas * agg not agging * try with global agg * global algo works * rm print statement * fmt * renamed files to be more precise * fixed something in docs * remove global functionality from local since this is done elsewhere * motif plotting capability * remove print statement oops * ordinal number for JOSS --------- Co-authored-by: Ben Steer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Array accumulators (thank you @fabianmurariu !) and global motif counting algo
Why are the changes needed?
Other algorithm was storing results per vertex in memory till right at the end, this is a massive memory hog unless you particularly care about the local results, especially if you're running with multiple time deltas
Does this PR introduce any user-facing change? If yes is this documented?
TBC
How was this patch tested?
Small unit test
Are there any further changes required?
need to expose to python + add back in the array acc test