Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingestor tidy up #1675

Closed
4 of 6 tasks
miratepuffin opened this issue Jun 26, 2024 · 0 comments · Fixed by #1714
Closed
4 of 6 tasks

Ingestor tidy up #1675

miratepuffin opened this issue Jun 26, 2024 · 0 comments · Fixed by #1714
Assignees
Labels
Connector Data ingestion or export to other tools

Comments

@miratepuffin
Copy link
Collaborator

miratepuffin commented Jun 26, 2024

For the pandas and Parquet loader we want to do the following:

  • Bring the order of required arguments in line with add_node/add_edge - this means instead of src,dst, time it should be time, src, dst. Bring pandas/parquet loaders api args inline with add_nodes/add_edges #1673

    • This should be on the following functions load_edge_props_from_pandas, load_edges_from_pandas, load_from_pandas, load_node_props_from_pandas, load_nodes_from_pandas, load_edge_props_from_parquet, load_edges_from_pandas, load_from_pandas, load_node_props_from_pandas, load_nodes_from_parquet
  • Any reference to const_properties should be changed to constant_properties

  • Add node_type col to load_node_props_from_pandas/parquet #1674

  • We need to replace layer/layer_in_df with layer_nameand layer_col: Option<&str> and simply raise a runtime error if both are specified at the same time

  • We need to replace node_type/node_type_in_df with node_typeand node_type_col: Option<&str> and simply raise a runtime error if both are specified at the same time

  • Will need to update docs when this is done

@miratepuffin miratepuffin added the Connector Data ingestion or export to other tools label Jun 26, 2024
@shivamka1 shivamka1 mentioned this issue Aug 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Data ingestion or export to other tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants