Feature/create node (#1855)

* add create_node and test * add create node to py * add create node to graphql * fmt * ref * ref * add tests * fmt --------- Co-authored-by: Shivam Kapoor <[email protected]>
Pometry · Nov 15, 2024 · a9a16ba · a9a16ba
1 parent b6f020c
commit a9a16ba
Show file tree

Hide file tree

Showing 9 changed files with 443 additions and 93 deletions.
diff --git a/python/tests/graphql/edit_graph/test_graphql.py b/python/tests/graphql/edit_graph/test_graphql.py
@@ -3,7 +3,7 @@
 
 import pytest
 
-from raphtory.graphql import GraphServer, RaphtoryClient, encode_graph
+from raphtory.graphql import GraphServer, RaphtoryClient, encode_graph, RemoteGraph
 from raphtory import graph_loader
 from raphtory import Graph
 import json
@@ -21,8 +21,8 @@ def test_encode_graph():
 
     encoded = encode_graph(g)
     assert (
-        encoded
-        == "EgxaCgoIX2RlZmF1bHQSDBIKCghfZGVmYXVsdBoFCgNiZW4aCQoFaGFtemEYARoLCgdoYWFyb29uGAIiAhABIgYIAhABGAEiBBACGAIqAhoAKgQSAhABKgQSAhADKgIKACoGEgQIARABKgYSBAgBEAIqBAoCCAEqBhIECAIQAioGEgQIAhADKgQKAggCKgQ6AhABKgIyACoIOgYIARACGAEqBDICCAEqCDoGCAIQAxgCKgQyAggC"
+            encoded
+            == "EgxaCgoIX2RlZmF1bHQSDBIKCghfZGVmYXVsdBoFCgNiZW4aCQoFaGFtemEYARoLCgdoYWFyb29uGAIiAhABIgYIAhABGAEiBBACGAIqAhoAKgQSAhABKgQSAhADKgIKACoGEgQIARABKgYSBAgBEAIqBAoCCAEqBhIECAIQAioGEgQIAhADKgQKAggCKgQ6AhABKgIyACoIOgYIARACGAEqBDICCAEqCDoGCAIQAxgCKgQyAggC"
     )
 
 
@@ -42,8 +42,8 @@ def test_wrong_url():
     with pytest.raises(Exception) as excinfo:
         client = RaphtoryClient("http://broken_url.com")
     assert (
-        str(excinfo.value)
-        == "Could not connect to the given server - no response --error sending request for url (http://broken_url.com/)"
+            str(excinfo.value)
+            == "Could not connect to the given server - no response --error sending request for url (http://broken_url.com/)"
     )
 
 
@@ -382,6 +382,170 @@ def test_graph_properties_query():
         )
 
 
+def test_create_node():
+    g = Graph()
+    g.add_edge(1, "ben", "shivam")
+
+    tmp_work_dir = tempfile.mkdtemp()
+    with GraphServer(tmp_work_dir).start(port=1737):
+        client = RaphtoryClient("http://localhost:1737")
+        client.send_graph(path="g", graph=g)
+
+        query_nodes = """{graph(path: "g") {nodes {list {name}}}}"""
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben"}, {"name": "shivam"}]
+                }
+            }
+        }
+
+        create_node_query = """{updateGraph(path: "g") { createNode(time: 0, name: "oogway") {  success } }}"""
+
+        assert client.query(create_node_query) == {"updateGraph": {"createNode": {"success": True}}}
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben"}, {"name": "shivam"}, {"name": "oogway"}]
+                }
+            }
+        }
+
+        with pytest.raises(Exception) as excinfo:
+            client.query(create_node_query)
+
+        assert "Node already exists" in str(excinfo.value)
+
+
+def test_create_node_using_client():
+    g = Graph()
+    g.add_edge(1, "ben", "shivam")
+
+    tmp_work_dir = tempfile.mkdtemp()
+    with GraphServer(tmp_work_dir).start(port=1737):
+        client = RaphtoryClient("http://localhost:1737")
+        client.send_graph(path="g", graph=g)
+
+        query_nodes = """{graph(path: "g") {nodes {list {name}}}}"""
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben"}, {"name": "shivam"}]
+                }
+            }
+        }
+
+        remote_graph = client.remote_graph(path="g")
+        remote_graph.create_node(timestamp=0, id="oogway")
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben"}, {"name": "shivam"}, {"name": "oogway"}]
+                }
+            }
+        }
+
+        with pytest.raises(Exception) as excinfo:
+            remote_graph.create_node(timestamp=0, id="oogway")
+
+        assert "Node already exists" in str(excinfo.value)
+
+
+def test_create_node_using_client_with_properties():
+    g = Graph()
+    g.add_edge(1, "ben", "shivam")
+
+    tmp_work_dir = tempfile.mkdtemp()
+    with GraphServer(tmp_work_dir).start(port=1737):
+        client = RaphtoryClient("http://localhost:1737")
+        client.send_graph(path="g", graph=g)
+
+        query_nodes = """{graph(path: "g") {nodes {list {name, properties { keys }}}}}"""
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben", 'properties': {'keys': []}}, {"name": "shivam", 'properties': {'keys': []}}]
+                }
+            }
+        }
+
+        remote_graph = client.remote_graph(path="g")
+        remote_graph.create_node(timestamp=0, id="oogway", properties={"prop1": 60, "prop2": 31.3, "prop3": "abc123", "prop4": True, "prop5": [1, 2, 3]})
+        nodes = json.loads(json.dumps(client.query(query_nodes)))['graph']['nodes']['list']
+        node_oogway = next(node for node in nodes if node['name'] == 'oogway')
+        assert sorted(node_oogway['properties']['keys']) == ['prop1', 'prop2', 'prop3', 'prop4', 'prop5']
+
+        with pytest.raises(Exception) as excinfo:
+            remote_graph.create_node(timestamp=0, id="oogway", properties={"prop1": 60, "prop2": 31.3, "prop3": "abc123", "prop4": True, "prop5": [1, 2, 3]})
+
+        assert "Node already exists" in str(excinfo.value)
+
+
+def test_create_node_using_client_with_properties_node_type():
+    g = Graph()
+    g.add_edge(1, "ben", "shivam")
+
+    tmp_work_dir = tempfile.mkdtemp()
+    with GraphServer(tmp_work_dir).start(port=1737):
+        client = RaphtoryClient("http://localhost:1737")
+        client.send_graph(path="g", graph=g)
+
+        query_nodes = """{graph(path: "g") {nodes {list {name, nodeType, properties { keys }}}}}"""
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben", 'nodeType': None, 'properties': {'keys': []}}, {"name": "shivam", 'nodeType': None, 'properties': {'keys': []}}]
+                }
+            }
+        }
+
+        remote_graph = client.remote_graph(path="g")
+        remote_graph.create_node(timestamp=0, id="oogway", properties={"prop1": 60, "prop2": 31.3, "prop3": "abc123", "prop4": True, "prop5": [1, 2, 3]}, node_type="master")
+        nodes = json.loads(json.dumps(client.query(query_nodes)))['graph']['nodes']['list']
+        node_oogway = next(node for node in nodes if node['name'] == 'oogway')
+        assert node_oogway['nodeType'] == 'master'
+        assert sorted(node_oogway['properties']['keys']) == ['prop1', 'prop2', 'prop3', 'prop4', 'prop5']
+
+        with pytest.raises(Exception) as excinfo:
+            remote_graph.create_node(timestamp=0, id="oogway", properties={"prop1": 60, "prop2": 31.3, "prop3": "abc123", "prop4": True, "prop5": [1, 2, 3]}, node_type="master")
+
+        assert "Node already exists" in str(excinfo.value)
+
+
+def test_create_node_using_client_with_node_type():
+    g = Graph()
+    g.add_edge(1, "ben", "shivam")
+
+    tmp_work_dir = tempfile.mkdtemp()
+    with GraphServer(tmp_work_dir).start(port=1737):
+        client = RaphtoryClient("http://localhost:1737")
+        client.send_graph(path="g", graph=g)
+
+        query_nodes = """{graph(path: "g") {nodes {list {name, nodeType}}}}"""
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben", 'nodeType': None}, {"name": "shivam", 'nodeType': None}]
+                }
+            }
+        }
+
+        remote_graph = client.remote_graph(path="g")
+        remote_graph.create_node(timestamp=0, id="oogway", node_type="master")
+        assert client.query(query_nodes) == {
+            "graph": {
+                "nodes": {
+                    "list": [{"name": "ben", 'nodeType': None}, {"name": "shivam", 'nodeType': None}, {"name": "oogway", 'nodeType': "master"}]
+                }
+            }
+        }
+
+        with pytest.raises(Exception) as excinfo:
+            remote_graph.create_node(timestamp=0, id="oogway", node_type="master")
+
+        assert "Node already exists" in str(excinfo.value)
+
+
 # def test_disk_graph_name():
 #     import pandas as pd
 #     from raphtory import DiskGraphStorage