fix: errors in vmtx where p doesn't exist (#136)

Pomax · Oct 13, 2023 · 94d6955 · 94d6955
1 parent 7e8ae1d
commit 94d6955
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib-font.browser.js b/lib-font.browser.js
diff --git a/src/opentype/tables/simple/other/vmtx.js b/src/opentype/tables/simple/other/vmtx.js
@@ -1,4 +1,5 @@
 import { SimpleTable } from "../../simple-table.js";
+import lazy from "../../../../lazy.js";
 
 /**
  * The OpenType `vmtx` table.
@@ -11,15 +12,15 @@ import { SimpleTable } from "../../simple-table.js";
  */
 class vmtx extends SimpleTable {
   constructor(dict, dataview, tables) {
-    super(dict, dataview);
+    const { p } = super(dict, dataview);
     const numOfLongVerMetrics = tables.vhea.numOfLongVerMetrics;
     const numGlyphs = tables.maxp.numGlyphs;
 
     const metricsStart = p.currentPosition;
     lazy(this, `vMetrics`, () => {
       p.currentPosition = metricsStart;
       return [...new Array(numOfLongVerMetrics)].map(
-        (_) => new LongVertMetric(p.uint16, p.int16)
+        (_) => new LongVerMetric(p.uint16, p.int16)
       );
     });
 
@@ -35,7 +36,8 @@ class vmtx extends SimpleTable {
   }
 }
 
-class LongVertMetric {
+class LongVerMetric {
+  // https://learn.microsoft.com/en-us/typography/opentype/spec/vmtx#vertical-metrics-table-format
   constructor(h, b) {
     this.advanceHeight = h;
     this.topSideBearing = b;