Allow restoreFocusOnClose to be set on paper-dropdown-menu #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paper-dropdown-menu creates a child paper-menu-button. Paper-menu-button has a restore-focus-on-close property, but there is currently no way for components with a paper-dropdown-menu to set this property. This will allow components with a paper-dropdown-menu to choose not to have focus set on the menu when the menu closes.
|
LGTM provided tests are green 💚 |
|
Polylint errors in travis... @rictic any idea on this one? |
|
This is googlearchive/polylint#149 (old linter). I'll ping that PR again. |
|
polylint updated and published, this PR lints clean now |
|
@lesliana I realize now that this property should have also been exposed by |
lesliana
added a commit
to lesliana/paper-dropdown-menu
that referenced
this pull request
Jan 31, 2017
See PolymerElements#227 for the same change on paper-dropdown-menu.
|
Yes, I had thought about that and asked about it over chat before creating the pull request but didn't hear a response, so I figured I'd just go ahead with paper-dropdown-menu only. I created the new PR: #230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paper-dropdown-menu creates a child paper-menu-button. Paper-menu-button has a restore-focus-on-close property, but there is currently no way for components with a paper-dropdown-menu to set this property. This will allow components with a paper-dropdown-menu to choose not to have focus set on the menu when the menu closes.