Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

<img> element should inherit border-radius from its parent. Fix #90 #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

derfel
Copy link

@derfel derfel commented Dec 17, 2016

I don't know if you want to add a specific mixin for the img element, but I think in the meantime you could apply this little patch to let fix #90.

If the img element inherit border-radius from its parent there's no need for a new mixin and it works with both shady and shadow dom.

For example:
iron-icon { --iron-icon: { border-radius: 50%; }; }

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@derfel
Copy link
Author

derfel commented Dec 22, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dominik0711
Copy link

Is there a road-map when the patch from @derfel will be merged into the upcoming release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round image inside iron-image
3 participants