Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Fix: iron-meta not being created in chrome 60 #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

admwx7
Copy link

@admwx7 admwx7 commented Jul 26, 2017

Turns out that _meta is not getting created with the definition for iron-meta in chrome 60.

This might address #105 as well.

@stramel will follow up with an update to travis to get it running in chrome 60.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@stramel
Copy link

stramel commented Aug 7, 2017

@e111077 @bicknellr PTAL

@notwaldorf
Copy link
Contributor

Is this to fix #109? If so, the problem is something in the webcomponents polyfill, not the element itself

@stramel
Copy link

stramel commented Aug 9, 2017

@notwaldorf I couldn't get it to pass shady dom with 1.0.6 or 1.0.7 running through polymer serve on https://github.com/MaritzSTL/mtz-update-password. However, travis ran it headless and it passed. Not sure if the webcomponents polyfill fixed it or not?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants