Merge pull request #17 from PolymerLabs/replace

Add replace nodes
Polymer · Apr 23, 2015 · a77c352 · a77c352
2 parents 0650779 + ad97986
commit a77c352
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/dom5.js b/dom5.js
@@ -333,6 +333,11 @@ function newElement(tagName, namespace) {
   };
 }
 
+function replace(oldNode, newNode) {
+  insertBefore(oldNode.parentNode, oldNode, newNode);
+  remove(oldNode);
+}
+
 function remove(node) {
   var parent = node.parentNode;
   if (parent) {
@@ -379,6 +384,7 @@ module.exports = {
   getTextContent: getTextContent,
   setTextContent: setTextContent,
   remove: remove,
+  replace: replace,
   append: append,
   insertBefore: insertBefore,
   normalize: normalize,

diff --git a/test/dom5_test.js b/test/dom5_test.js
@@ -253,6 +253,17 @@ suite('dom5', function() {
       });
     });
 
+    suite('Replace node', function() {
+      test('New node replaces old node', function() {
+        var divA = doc.childNodes[1].childNodes[1].childNodes[0];
+        var newNode = dom5.constructors.element('ul');
+        dom5.replace(divA, newNode);
+        assert.equal(divA.parentNode, null);
+        assert.equal(doc.childNodes[1].childNodes[1].childNodes.indexOf(divA), -1);
+        assert.equal(doc.childNodes[1].childNodes[1].childNodes.indexOf(newNode), 0);
+      });
+    });
+
     suite('Remove node', function() {
       test('node is removed from parentNode', function() {
         var divA = doc.childNodes[1].childNodes[1].childNodes[0];