Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.5 to travis builds #63

Merged
merged 2 commits into from
Mar 29, 2016
Merged

add python 3.5 to travis builds #63

merged 2 commits into from
Mar 29, 2016

Conversation

dzen
Copy link
Contributor

@dzen dzen commented Dec 19, 2015

refs #50 issue.

@leth
Copy link

leth commented Mar 29, 2016

Looking into the test failures, there seems to be some problem in pyrabbit's use of httplib2 on python 3.5.
Pyrabbit master has switched to requests instead of httplib2, which should fix the problem.
watch out for the small rabbitmq API url change!

@dzen
Copy link
Contributor Author

dzen commented Mar 29, 2016

hello @leth

yes exactly, but we often rely on project releases :/
I think pyrabbit probably should rely on requests since the httplib2 maintainer just give up maintaining another http lib: http://bitworking.org/news/2016/03/an_update_on_httplib2

@dzen dzen force-pushed the dzen/python35_compat branch from 18856bd to 9645073 Compare March 29, 2016 12:34
@leth
Copy link

leth commented Mar 29, 2016

You could instead use pyrabbit from git instead of httplib2!

@dzen
Copy link
Contributor Author

dzen commented Mar 29, 2016

Got it now : Latest commit 5630e73 on Dec 24, 2015 @bkjones bkjones Replace httplib2 with requests

@dzen
Copy link
Contributor Author

dzen commented Mar 29, 2016

Seems that this pyrabbit version calls /vhosts/ instead of /api/vhosts/

digging.

@dzen dzen force-pushed the dzen/python35_compat branch from 9645073 to 8add470 Compare March 29, 2016 12:56
@leth
Copy link

leth commented Mar 29, 2016

Yep; the string you give to pyrabbit has changed from localhost:port to localhost:port/api.
I think I saw it in the readme.
You might also need a trailing / on the URL, but that is probably a bug on their part.

@leth
Copy link

leth commented Mar 29, 2016

Ah you already found that!

@dzen
Copy link
Contributor Author

dzen commented Mar 29, 2016

Do you mind if I ask you to test it a little bit on python 3.5 ? I mean, if you have a larger project.

@dzen dzen force-pushed the dzen/python35_compat branch from 8add470 to 0d5bfc5 Compare March 29, 2016 13:50
@dzen
Copy link
Contributor Author

dzen commented Mar 29, 2016

I rebase, and I'm ready to push this on master.

@leth
Copy link

leth commented Mar 29, 2016

Thanks!
We're not quite ready to test things out immediately; we were just looking into our dependencies before we started. We'll get back to you when we get a chance to do so!

@leth
Copy link

leth commented Mar 29, 2016

Also: you might wish to update the classifiers in setup.py :)

@dzen
Copy link
Contributor Author

dzen commented Mar 29, 2016

I didn't updated the modifiers since I can't test if aioamqp works well with 3.5. I can't guarantee that

@dzen dzen merged commit 0d5bfc5 into master Mar 29, 2016
@leth
Copy link

leth commented Mar 29, 2016

Fair enough

@RemiCardona RemiCardona deleted the dzen/python35_compat branch April 4, 2016 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants