-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python 3.5 to travis builds #63
Conversation
Looking into the test failures, there seems to be some problem in pyrabbit's use of httplib2 on python 3.5. |
hello @leth yes exactly, but we often rely on project releases :/ |
18856bd
to
9645073
Compare
You could instead use pyrabbit from git instead of httplib2! |
Got it now : Latest commit 5630e73 on Dec 24, 2015 @bkjones bkjones Replace httplib2 with requests |
Seems that this pyrabbit version calls /vhosts/ instead of /api/vhosts/ digging. |
9645073
to
8add470
Compare
Yep; the string you give to pyrabbit has changed from |
Ah you already found that! |
Do you mind if I ask you to test it a little bit on python 3.5 ? I mean, if you have a larger project. |
8add470
to
0d5bfc5
Compare
I rebase, and I'm ready to push this on master. |
Thanks! |
Also: you might wish to update the classifiers in setup.py :) |
I didn't updated the modifiers since I can't test if aioamqp works well with 3.5. I can't guarantee that |
Fair enough |
refs #50 issue.