Remove port from default MPD_HOST warning
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if both `MPD_HOST` and `MPD_PORT` environment variables are not set, you would get two warnings, e.g.: > [2024-01-08T08:54:08Z WARN blissify] Could not find any MPD_HOST environment variable set. Defaulting to 127.0.0.1:6600. > [2024-01-08T08:54:08Z WARN blissify] Could not find any MPD_PORT environment variable set. Defaulting to 6600. where the port 6600 is repeated in both messages. This can be misleading in case the user has only `MPD_PORT` set to e.g. 6601 - the user would get the first warning: > [2024-01-08T08:54:08Z WARN blissify] Could not find any MPD_HOST environment variable set. Defaulting to 127.0.0.1:6600. but blissify would be acutally connecting on the 6601 port, which would be misleading. Also, in the code, the port is not being set when `MPD_HOST` is not set.
|
Makes sense - that's also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if both
MPD_HOSTandMPD_PORTenvironment variables are not set, you would get two warnings, e.g.:where the port 6600 is repeated in both messages. This can be misleading in case the user has only
MPD_PORTset to e.g. 6601 - the user would get the first warning:but blissify would be acutally connecting on the 6601 port, which would be misleading.
Also, in the code, the port is not being set when
MPD_HOSTis not set.