Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decoder.rs #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

chourmovs
Copy link

I had following error when compiling on x86

error[E0063]: missing field safe in initializer of Config
--> /home/volumio/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bliss-audio-0.8.0/src/song/decoder.rs:458:39
|
458 | context.set_threading(Config {
| ^^^^^^ missing safe

I had following error when compiling on x86

error[E0063]: missing field safe in initializer of Config
   --> /home/volumio/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bliss-audio-0.8.0/src/song/decoder.rs:458:39
    |
458 |                 context.set_threading(Config {
    |                                       ^^^^^^ missing safe
@Polochon-street
Copy link
Owner

Hi,

What version of ffmpeg are you using? I don't think this is going to fix your issue, since it seems that it's complaining that the field simply doesn't exist.

@Polochon-street
Copy link
Owner

(and also, what command did you use to try and compile it?)

@chourmovs
Copy link
Author

ffmpeg version 4.1.9-0+deb10u1 Copyright (c) 2000-2022 the FFmpeg developers
  built with gcc 8 (Debian 8.3.0-6)
  configuration: --prefix=/usr --extra-version=0+deb10u1 --toolchain=hardened --libdir=/usr/lib/arm-linux-gnueabihf --incdir=/usr/include/arm-linux-gnueabihf --arch=arm --enable-gpl --disable-stripping --enable-avresample-filter=resample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libcodec2 --enable-libflite --enable-libfonenable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libjack --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librsvg -brubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwavpack --enabl--enable-libx265 --enable-libxml2 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-lv2 --enable-omx --enable-openal --enable-opengl --enable-sdl2 --enable-libdc1394 --enable-libdrm --enable-libiec61883 --enable-t --enable-frei0r --enable-libx264 --enable-shared
  libavutil      56. 22.100 / 56. 22.100
  libavcodec     58. 35.100 / 58. 35.100
  libavformat    58. 20.100 / 58. 20.100
  libavdevice    58.  5.100 / 58.  5.100
  libavfilter     7. 40.101 /  7. 40.101
  libavresample   4.  0.  0 /  4.  0.  0
  libswscale      5.  3.100 /  5.  3.100
  libswresample   3.  3.100 /  3.  3.100
  libpostproc    55.  3.100 / 55.  3.100

I just ran cargo install blissify -j 1, twice with same error

My patch proposition is a workaround proposition that worked for me, but i didn't dive into code, so you surely can do better

@Polochon-street
Copy link
Owner

hmm, it's weird, it seems that rust-ffmpeg is compiled for a version of ffmpeg < 6.0, but bliss-rs gets a version that's > 6.0. Could you perhaps run cargo clean and paste the output of cargo install blissify --verbose, with a non-modified master?
You shouldn't be encountering the error you're running into :D

@chourmovs
Copy link
Author

Ok I'll try ASAP. thx

@Polochon-street
Copy link
Owner

hi @chourmovs, it was a problem with the way ffmpeg was handling things, it should be fixed in the latest master. I'll let you know when I push a new version to crates.io :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants