fix: displaying locked amount button

[AMIRKHANEF]

Close: #1559

Summary by CodeRabbit

• New Features

  • Enhanced the AmountWithOptions component to conditionally enable the secondary action based on the presence of a valid locked amount.

• Bug Fixes

  • Improved handling of the onSecondary prop to ensure it only activates when there is a locked amount available.

• Improvements

  • Modified the AlreadyLockedTooltipText component for better readability while maintaining existing functionality.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

packages/extension-polkagate/src/fullscreen/governance/delegate/partial/AmountWithOptionsAndLockAmount.tsx (2)

106-106: LGTM! The conditional rendering addresses the issue effectively.

The implementation correctly hides the locked amount button when there's no locked amount available, directly addressing the issue from #1559. The null checks and conditional logic are properly implemented.

Consider extracting the condition to a descriptive variable for improved readability:

-        onSecondary={lockedAmount && !lockedAmount?.isZero() ? onLockedAmount : undefined}
+        const hasLockedAmount = lockedAmount && !lockedAmount?.isZero();
+        onSecondary={hasLockedAmount ? onLockedAmount : undefined}

---

Line range hint 1-120: Component architecture aligns well with the change.

The component's structure effectively supports the conditional rendering of the locked amount button:

• The VotingInformation subcomponent already implements similar conditional rendering for locked amount display
• The Props interface properly types all required properties
• The memoization of alreadyLockedTooltipText helps with performance

Consider extracting the locked amount visibility logic into a custom hook if this condition needs to be reused elsewhere in the application.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between abb0241 and 7381a84.

📒 Files selected for processing (1)

• packages/extension-polkagate/src/fullscreen/governance/delegate/partial/AmountWithOptionsAndLockAmount.tsx (1 hunks)

[coderabbitai]

Walkthrough

The changes focus on the AmountWithOptionsAndLockAmount component within the AmountWithOptionsAndLockAmount.tsx file. The primary modification involves the conditional assignment of the onSecondary prop based on the state of lockedAmount. If lockedAmount is defined and not zero, onLockedAmount is assigned; otherwise, onSecondary is set to undefined. This adjustment ensures the secondary action is only available when there is a valid locked amount, impacting the component's behavior in specific scenarios.

Changes

File	Change Summary
packages/extension-polkagate/src/fullscreen/governance/delegate/partial/AmountWithOptionsAndLockAmount.tsx	Modified handling of onSecondary prop in AmountWithOptions component based on lockedAmount state.

Assessment against linked issues

Objective	Addressed	Explanation
Fix useless locked amount button on delegate vote page when there is no locked amount (#1559)	✅

Possibly related PRs

• fix: underway votes type #1625: This PR modifies the same AmountWithOptionsAndLockAmount.tsx file and introduces a new component related to locked amounts, which is directly relevant to the changes made in the main PR regarding the handling of the lockedAmount state.

Poem

🐰 In the garden where tokens play,
A locked amount found its way.
No more buttons that lead to naught,
Only actions when value is sought.
With a hop and a skip, we cheer,
For clearer paths now, far and near! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7381a84 and cf41c38.

📒 Files selected for processing (1)

• packages/extension-polkagate/src/fullscreen/governance/delegate/partial/AmountWithOptionsAndLockAmount.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/extension-polkagate/src/fullscreen/governance/delegate/partial/AmountWithOptionsAndLockAmount.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.