fix: displaying reactions issue

[AMIRKHANEF]

Close: #1595

Summary by CodeRabbit

• New Features

  • Enhanced user data structure for reactions, allowing for more detailed user information (address, publicKey, username).
  • Improved accuracy in reaction counts by aggregating all user addresses instead of just the first user.

• Bug Fixes

  • Ensured consistency in the representation of reaction data across main comments and replies.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the helpers.ts file in the governance utilities of the PolkaGate extension. The ReactionSS interface has been updated to change the user property type, allowing for a more structured representation of user data. Additionally, the getReferendumCommentsSS function has been altered to improve how user reactions are aggregated, ensuring that all user addresses are counted in reaction data. The overall control flow and error handling mechanisms remain unchanged.

Changes

File Path	Change Summary
packages/extension-polkagate/src/fullscreen/governance/utils/helpers.ts	Updated ReactionSS interface to modify user property type; altered getReferendumCommentsSS function to aggregate all user addresses in reactions.

Possibly related PRs

• fix: update referendum comments #1548: This PR modifies the Comment.tsx file, which is related to the handling of user reactions and the display of comment metadata, directly connecting to the changes made in the helpers.ts file regarding the ReactionSS interface and the getReferendumCommentsSS function.

Suggested labels

change requested

Poem

🐰 In the land of code where rabbits play,
User reactions now brighten the day.
With addresses gathered, all in a row,
Comments and laughter, together they flow.
Hopping through changes, with joy we decree,
A better structure for you and for me! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/extension-polkagate/src/fullscreen/governance/utils/helpers.ts (1)

466-466: LGTM! Consider a minor optimization for reaction aggregation.

The changes improve the accuracy of reaction data by aggregating addresses of all users who reacted. This enhancement applies to both main comments and replies, ensuring consistency in reaction representation.

Consider using the filter method to exclude null values and simplify the code:

-'👍': { count: reactions.length, usernames: reactions.map((reaction) => reaction.user?.address ?? '') ?? null },
+'👍': { count: reactions.length, usernames: reactions.map((reaction) => reaction.user?.address).filter(Boolean) },

This change would eliminate empty strings from the usernames array, potentially improving data quality.

Also applies to: 481-481

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b2ca99d and fad0ba7.

📒 Files selected for processing (1)

• packages/extension-polkagate/src/fullscreen/governance/utils/helpers.ts (3 hunks)

🧰 Additional context used

🔇 Additional comments (2)

packages/extension-polkagate/src/fullscreen/governance/utils/helpers.ts (2)

Line range hint 1-502: Overall assessment: Changes improve data structure and accuracy.

The modifications to the ReactionSS interface and getReferendumCommentsSS function enhance the structure of user data and improve the accuracy of reaction aggregation. These changes align well with the PR objectives of fixing the displaying reaction issue.

To ensure a smooth integration of these changes:

1. Verify that all usages of the ReactionSS interface have been updated accordingly.
2. Consider the suggested optimization for reaction aggregation to further improve data quality.
3. Conduct thorough testing to confirm that the changes resolve the displaying reaction issue as intended.

---

103-107: LGTM! Verify usage of the updated ReactionSS interface.

The ReactionSS interface has been improved to provide more structured user data. This change enhances type safety and provides more detailed information about the user associated with a reaction.

Please ensure that all usages of the ReactionSS interface have been updated to accommodate this change. Run the following script to verify: