Services and characteristics list #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelByszewski
requested changes
Jan 10, 2020
example/lib/peripheral_details/components/peripheral_details_view.dart
Outdated
Show resolved
Hide resolved
example/lib/peripheral_details/components/peripheral_details_view.dart
Outdated
Show resolved
Hide resolved
TomoLV
suggested changes
Jan 20, 2020
example/lib/peripheral_details/components/peripheral_details_view.dart
Outdated
Show resolved
Hide resolved
example/lib/peripheral_details/components/peripheral_details_view.dart
Outdated
Show resolved
Hide resolved
example/lib/peripheral_details/components/peripheral_details_view.dart
Outdated
Show resolved
Hide resolved
… example/services-list # Conflicts: # example/lib/peripheral_details/components/peripheral_details_view.dart
martawoldanska
force-pushed
the
example/services-list
branch
from
4a78702 to
64904f9
Compare
TomoLV
previously approved these changes
Jan 23, 2020
pawelByszewski
requested changes
Jan 24, 2020
| sliver: SliverToBoxAdapter( | ||
| child: BlocBuilder<PeripheralDetailsBloc, PeripheralDetailsState>( | ||
| builder: (context, state) { | ||
| return Column( |
There was a problem hiding this comment.
is it redrawn when any of serviceState.expanded has been changed?
There was a problem hiding this comment.
As far as I understand it, only the changed view will be redrawn. Whole column view would be rebuilt each time expanded state changes, but only changed part would be actually redrawn.
| ], | ||
| ); | ||
| } | ||
|
|
||
| Widget _createServiceView( |
There was a problem hiding this comment.
I am wondering, maybe it(Services view) should be extracted to separate view/widget/file?
| @override | ||
| List<Object> get props => [index]; | ||
|
|
||
| final int index; |
There was a problem hiding this comment.
index of what? imho it should be more meaningful
example/test/peripheral_details/peripheral_details_bloc_test.dart
Outdated
Show resolved
Hide resolved
|
|
dariuszseweryn
previously approved these changes
Feb 4, 2020
pawelByszewski
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.