Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented suggest change of renaming locations.csv id=768 to malie-city--proper #1098

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

O-Tahmas
Copy link
Contributor

This PR addresses the issue of duplicate location entries in locations.csv for malie-city. Currently, both id=768 and id=1045 are listed as malie-city. To resolve this, id=768 has been renamed to malie-city--proper.

This change ensures that all (region_id, identifier) combinations in locations.csv are unique, maintaining data integrity and clarity for location entries.

@Naramsim
Copy link
Member

Naramsim commented Jun 2, 2024

Hi! Why the double --?

@O-Tahmas
Copy link
Contributor Author

O-Tahmas commented Jun 2, 2024

Hi! Why the double --?

Hey!
I just copied & pasted from the issue thread to be safe :)
#1097

@Naramsim
Copy link
Member

Naramsim commented Jun 3, 2024

Yeah, but that's not a valid reason 😂😂.

I'd say we go with the single one. Or maybe you can tag the guy who replied to you on the other issues

@Naramsim
Copy link
Member

Hi @O-Tahmas , can you remove one dash so we can merge?

@O-Tahmas
Copy link
Contributor Author

So sorry! Thought I pushed the change.

@Naramsim Naramsim merged commit dc8e651 into PokeAPI:master Jul 16, 2024
2 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants