This repository has been archived by the owner on Dec 23, 2020. It is now read-only.
Add Blake2b #164
Merged
Add Blake2b #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it'd be nice if this PR could work on top of the commits from #113. Both to give credit to the original author and to have the name of the implementer on top of the commit in case someone has questions about it later. |
|
In that case, I could merge this next week and put it into a release as well. |
|
I'll rebase it soon, originally it was just for personal usage but I'll redo it to preserve the original commits |
|
Thanks! |
The implementation was ported from Bouncy Castle.
|
@stevenroose Re-based this pull request to include @jminer's commit |
stevenroose
suggested changes
Feb 20, 2019
test/test/digest_tests.dart
Outdated
| @@ -31,5 +33,14 @@ void _runDigestTest( | |||
| var out = digest.process(plainText); | |||
| var hexOut = formatBytesAsHexString(out); | |||
|
|
|||
| expect(hexOut, equals(expectedHexDigestText)); | |||
|
|
|||
| f or(var i = 0; i < plainText.length; ++i) { | |||
There was a problem hiding this comment.
There is a type on this line.
There was a problem hiding this comment.
Pushed fix,
also confirmed test passes
00:00 +31: Blake2b: digest: (empty string)
00:00 +32: Blake2b: digest: Lorem ipsum dolor sit amet[...]
00:00 +33: Blake2b: digest: En un lugar de La Mancha, [...]
00:00 +34: Blake2b: digest: Lorem ipsum dolor sit amet[...]
00:00 +35: Blake2b: digest: Lorem ipsum dolor sit amet[...]
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #113.
I'm using this for a flutter crypto currency wallet I'm working on, as seen implemented in this package: https://github.com/bbedward/flutter_nano_core