Skip to content

Commit

Permalink
Update default port to 5001
Browse files Browse the repository at this point in the history
  • Loading branch information
pts-jweatherby committed Feb 29, 2024
1 parent b7c8358 commit aa2e5e6
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ To run it locally for development purposes, it runs like a typical flask app:
```python
export FLASK_APP=app:app
flask run [--reload]
# navigate to 127.0.0.1:5000
# navigate to 127.0.0.1:5001
```
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ ADD . /app
RUN pipenv install --ignore-pipfile --system --deploy
RUN python generate-instructions.py

EXPOSE 5000
EXPOSE 5001

CMD gunicorn wsgi:app -w 2 -b :5000
CMD gunicorn wsgi:app -w 2 -b :5001
2 changes: 1 addition & 1 deletion Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ The application should have a very basic UI with a form that accepts two inputs:

### Sample Request

Please find a sample request at [/tax-calculator/](http://localhost:5000/tax-calculator/),
Please find a sample request at [/tax-calculator/](http://localhost:5001/tax-calculator/),
which contains a reliable API endpoint and can be used for test and development purposes.
It returns the following JSON response:

Expand Down Expand Up @@ -115,12 +115,12 @@ In order to run the API locally, please follow these instructions:

```bash
docker pull ptsdocker16/interview-test-server
docker run --init -p 5000:5000 -it ptsdocker16/interview-test-server
docker run --init -p 5001:5001 -it ptsdocker16/interview-test-server
```

Navigate to [http://localhost:5000](http://localhost:5000). You should be greeted with this set of instructions, and access to the different available endpoints. The following are the relevant endpoints:
Navigate to [http://localhost:5001](http://localhost:5001). You should be greeted with this set of instructions, and access to the different available endpoints. The following are the relevant endpoints:

* [/tax-calculator/](http://localhost:5000/tax-calculator/) - endpoint to develop against
* [/tax-calculator/](http://localhost:5001/tax-calculator/) - endpoint to develop against
* [/tax-calculator/tax-year/2022](/tax-calculator/tax-year/2022) - endpoint you'll be assessed against

If you have any problems or need any sort of clarification, email the engineering hiring manager for assistance.
Expand Down

0 comments on commit aa2e5e6

Please sign in to comment.