Replace BOOST_MPL_ASSERT by static_assert #5525
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the static code analysis of MSVC is enabled, you are getting a lot of messages like:
The reason is that the
BOOST_MPL_ASSERT
macros are for pre C++11, wherestatic_assert
didn't exists. Sadly these macros are still using static variable (see implementation ofBOOST_MPL_ASSERT_MSG_IMPL
).This small MR reduces the number of warnings during compilation by 221 unique messages (with duplicates 5.778).
Split from #5522 as it changes the compiler output, so in case there will be some discussion.
Output with Boost implementation:
Output with
static_assert
: