Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf extension added #592 #593

Closed
wants to merge 6 commits into from
Closed

pdf extension added #592 #593

wants to merge 6 commits into from

Conversation

ettolrah
Copy link
Contributor

fixing issue #592

mchurchward
mchurchward requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the ".idea" directory from your commit. Also, please rebase with the latest MOODLE_401_STABLE to reenable to CI tests.

@mchurchward
Copy link
Contributor

My apologies, but due to a force push, you need to rebase your PR with MOODLE_401_STABLE one more time.

@mchurchward
Copy link
Contributor

Did you pull the latest MOODLE_401_STABLE before rebasing? You still have extra commits in your PR that shouldn't be there.

@mchurchward
Copy link
Contributor

To make it easier, I just cherry-picked your fix into the branch. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchurchward mchurchward mchurchward requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ettolrah @mchurchward @lucaboesch @Syxton @FelixDiLenarda