Expand search to search music, title, person and other changes #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Set to draft while I add a commit to handle URL in search dialog. Title and person show "add" message when the feed actually already exists in the index. |
ScreenshotsNew search field in topbar All resutls Music resutls Title results Person results, no results Person results with matching episodes and player on results page. Click chain icon to link to episode on PodcastIndex.org. When loading page with episode, will scroll to episode. Episode name in player will also link to episode page |
|
This looks really good Steven. I’m not qualified to reviews the code but I will if someone else more Reacty doesn’t step in. The screenshots look great. 💪 |
|
Exposing person search and links to episodes is a long needed thing. |
Move episode list and player to separate component so it can be used on the podcast page and person search results. Attempt to sort music feeds based on the season and episode attributes. Sort live feeds by start time (newest first).
These types don't return results for URL so suggest All search instead before suggesting adding feed
Currently, the API will only return a max of 1000 items.
… sometimes take a long time to return
stevencrader
force-pushed
the
expand-search
branch
from
25fcf8d to
9cdd74a
Compare
|
You good to go on this? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move episode list and player to separate component so it can be used on the podcast page and person search results.
Attempt to sort music feeds based on the season and episode attributes.
Sort live feeds by start time (newest first)
The proposed way to link to an episode is in the format
/podcast/<feed_id>?episode=<episode_id>. Ex:/podcast/150842?episode=15569509454If a different URL scheme would be preferred, let me know.
This was added to support the person search but will resolve #76 and #63 too.
Other changes:
/podcast/e0ac9365-689c-5043-8804-15b9dfcc545awill replace url with/podcast/150842). This preserves the episode argument.