fix(login): hide external connection portal configuration to frontend configuration #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3330 +/- ##
===========================================
- Coverage 84.00% 83.99% -0.02%
===========================================
Files 122 122
Lines 9713 9719 +6
===========================================
+ Hits 8159 8163 +4
- Misses 1554 1556 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacquesfize
force-pushed
the
fix/external-login-security-breach
branch
from
e7a031b to
8e559cc
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GeoNature 2.15, connect to other identity providers was made possible. However, sensible configuration variable were made accessible in the frontend config returned in the public route
gn_commons/config.A notice must be made in GeoNature 2.15.0 and 2.15.1 to warn users to update the 2.15.2 version if they wish to use such functionnality !