[IMPORT] Feat context parameter import #3277
Draft
+280
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriacap
force-pushed
the
feat/context-parameter-import
branch
2 times, most recently
from
b4efac7 to
ef99612
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/import-monitorings #3277 +/- ##
========================================================
Coverage 83.94% 83.95%
========================================================
Files 122 122
Lines 9721 9727 +6
========================================================
+ Hits 8160 8166 +6
Misses 1561 1561
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andriacap
force-pushed
the
feat/context-parameter-import
branch
2 times, most recently
from
554881c to
aca2da1
Compare
andriacap
force-pushed
the
feat/context-parameter-import
branch
from
aca2da1 to
164e01e
Compare
jacquesfize
force-pushed
the
feat/import-monitorings
branch
from
2b5f26f to
dcc764e
Compare
- Format params to FieldsMapping interface - Send on upload route frontend - Set fieldsmapping for t_import on upload route backend Reviewed-by: andriacap
- Synthese test frontend (ok) - wip : make occhab condition and refact test Reviewed-by: andriacap
Use same attribute for QA in all elements in fields mapping step Reviewed-by: andriacap
Reviewed-by: andriacap
- Change fieldmapping for sample data - Add delete command to each test for fieldmapping context Reviewed-by: andriacap
Reviewed-by: andriacap
andriacap
force-pushed
the
feat/context-parameter-import
branch
from
3956690 to
85dca11
Compare
- Test upload_route with context parameter Reviewed-by: andriacap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TACHES PROJET IMPORT :
feat(wip): get context import by query params url
Format params to FieldsMapping interface
Send on upload route frontend
Set fieldsmapping for t_import on upload route backend
Test backend
Test frontend : un test e2e a été ajouté pour tester la fonctionnalité
Tests frontend existants : certains sont fonctionnels mais ne sont pas lié aux développements de cette fonctionnalité (à résoudre dans une autre PR ?)
Reviewed-by: andriacap
Tâche(s) dépendante(s)