Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended permissions: geographic & taxonomic filters, validation, … #3217

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

bouttier
Copy link
Contributor

@bouttier bouttier commented Oct 8, 2024

  • Flitre géographique (type de zonage définie via GEOGRAPHIC_FILTER_AREA_TYPES)
  • Filtre taxonomique
  • Date d’expiration des permissions
  • Statut de validation des permissions
  • API d’accès aux permissions disponible (pour usage du module de validation)

@bouttier bouttier force-pushed the feat/extended-permissions branch 4 times, most recently from db30f85 to 35d9228 Compare October 8, 2024 15:15
@bouttier bouttier force-pushed the feat/extended-permissions branch 3 times, most recently from 462b510 to be6579b Compare October 16, 2024 22:55
@bouttier bouttier force-pushed the feat/extended-permissions branch 2 times, most recently from 42ad4db to 9b1ce03 Compare November 20, 2024 13:02
@bouttier bouttier force-pushed the feat/extended-permissions branch from 9b1ce03 to d240f33 Compare November 20, 2024 13:07
@bouttier bouttier force-pushed the feat/extended-permissions branch from d240f33 to 779906d Compare November 20, 2024 15:23
@bouttier bouttier force-pushed the feat/extended-permissions branch from 779906d to 3914bec Compare November 20, 2024 15:27
@bouttier bouttier changed the title Draft: Extended permissions: geographic & taxonomic filters, validation, … Extended permissions: geographic & taxonomic filters, validation, … Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 76.21359% with 49 lines in your changes missing coverage. Please review.

Project coverage is 83.70%. Comparing base (b91808b) to head (3914bec).

Files with missing lines Patch % Lines
backend/geonature/core/gn_permissions/admin.py 40.00% 21 Missing ⚠️
backend/geonature/core/gn_permissions/schemas.py 74.07% 14 Missing ⚠️
backend/geonature/core/gn_permissions/models.py 76.47% 12 Missing ⚠️
backend/geonature/core/gn_synthese/models.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3217      +/-   ##
===========================================
- Coverage    83.84%   83.70%   -0.15%     
===========================================
  Files          122      122              
  Lines         9647     9802     +155     
===========================================
+ Hits          8089     8205     +116     
- Misses        1558     1597      +39     
Flag Coverage Δ
pytest 83.70% <76.21%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bouttier bouttier requested a review from jacquesfize November 20, 2024 15:49
@bouttier
Copy link
Contributor Author

La PR est OK pour merge. Elle contient les filtres + le nécessaire pour le fonctionnement d’un module de demande de permissions.

Le module de demande de permission nécessitera toutefois une évolution du front de GN pour permettre à ce dernier d’être accédé depuis le menu utilisateur en haut à droite, et non par le menu latéral de droite. Mais ceci pourra être fait dans une autre PR (et bien qu’inélégant dans le menu de droite, cela n’empêchera pas son fonctionnement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant