-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generic CIP30 wallets by name #1528
Conversation
Recreated from #1524. |
Nami only provides `getCollateral` under the experimental API | ||
*/ | ||
(typeof conn.getCollateral === "function" | ||
? conn.getCollateral("5000000") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This string value is probably incorrect. In the spec, it must be cbor-string of Coin type, not numeric literal.
We should pass the amount parameter from purescript. If we hardcode it, it must be hardcoded on PS side and then processed into cbor as usual |
Looks like this could actually be reverted to passing no arguments with the latest release of Yoroi: |
No, we must require it, because this is what CIP-30 tells us to do:
The current behavior is a bug. |
I'm taking this PR over |
Re-created here: #1536 |
Pre-review checklist
make format
)## Unreleased
header, using the appropriate sub-headings (### Added
,### Removed
,### Fixed
), and the links to the appropriate issues/PRs have been included