Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added singleCheckFatal on node.js #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madprogramer
Copy link

@madprogramer
Copy link
Author

Bump

@qparis
Copy link
Member

qparis commented Aug 3, 2022

I'm not sure we want PlayOnMac to be dependant on NodeJS as it is written in Python ; moreover, the default netcat works properly with PoM.

@madprogramer
Copy link
Author

madprogramer commented Aug 3, 2022

I still have no idea why PoM was looking for node, because I had python installed. But

The problem I had was that PoM was misreporting netcat as missing, when it was upset with node. Printing those

env: node: No such file or directory

messages. After re-installing node, PoM found netcat just fine. This fixes the issue on my machine, at least.

@qparis
Copy link
Member

qparis commented Aug 3, 2022

Yes, but it enforce every PoM users to have nodejs installed, which should not because PoM is not written in node.
We'd better find a way to understand why POM is not happy with your own netcat

@robert-scheck
Copy link
Contributor

The reporter most likely used https://www.npmjs.com/package/nc, https://github.com/roccomuso/nc or similar, which seems to install by default as /usr/local/bin/nc - just have a look with a text editor what your /usr/local/bin/nc contains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants